From 2f8284a38690932bb5c2fa773c5d93d5603f041b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Timm=20B=C3=A4der?= Date: Wed, 27 Jun 2018 17:58:01 +0200 Subject: [PATCH] testsuite: Remove a GtkColorButton special case The comment above explains neatly why subclassing GtkButton for GtkColorButton was a bad idea. Nowadays it's a GtkWidget subclass containing a GtkButton so let's remove the special case here. --- testsuite/gtk/notify.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/testsuite/gtk/notify.c b/testsuite/gtk/notify.c index f36fefd471..950f2884cc 100644 --- a/testsuite/gtk/notify.c +++ b/testsuite/gtk/notify.c @@ -509,13 +509,6 @@ test_type (gconstpointer data) g_str_equal (pspec->name, "draw-indicator")) continue; - /* Really a bug in the way GtkButton and its subclasses interact: - * setting label etc on a subclass destroys the content, breaking - * e.g. GtkColorButton pretty badly - */ - if (type == GTK_TYPE_COLOR_BUTTON && pspec->owner_type == GTK_TYPE_BUTTON) - continue; - /* Too many special cases involving -set properties */ if (g_str_equal (g_type_name (pspec->owner_type), "GtkCellRendererText") || g_str_equal (g_type_name (pspec->owner_type), "GtkTextTag")) -- 2.30.2